mumrah commented on code in PR #18218: URL: https://github.com/apache/kafka/pull/18218#discussion_r1890704140
########## clients/src/main/resources/common/message/FindCoordinatorRequest.json: ########## @@ -18,6 +18,8 @@ "type": "request", "listeners": ["zkBroker", "broker"], "name": "FindCoordinatorRequest", + // Versions 0 was removed in Apache Kafka 4.0, Version 1 is the new baseline. + // Review Comment: KIP states > FindCoordinator: none due to clients (Sarama, kafka-python) support – V0-V1 per the baseline Does this mean we should not be removing any versions? ########## clients/src/main/resources/common/message/CreateTopicsRequest.json: ########## @@ -18,6 +18,8 @@ "type": "request", "listeners": ["zkBroker", "broker", "controller"], "name": "CreateTopicsRequest", + // Versions 0-1 were removed in Apache Kafka 4.0, Version 2 is the new baseline. Review Comment: In the KIP, it states > CreateTopics: V0-V1 due to clients (Sarama) support – V0-V2 per the baseline Seems we are removing version 0 and 1. What does "V0-V2 per the baseline" mean for this and other RPCs? ########## clients/src/main/resources/common/message/DescribeConfigsResponse.json: ########## @@ -17,10 +17,11 @@ "apiKey": 32, "type": "response", "name": "DescribeConfigsResponse", + // Version 0 was removed in Apache Kafka 4.0, Version 1 is the new baseline. // Version 1 adds ConfigSource and the synonyms. // Starting in version 2, on quota violation, brokers send out responses before throttling. // Version 4 enables flexible versions. - "validVersions": "0-4", Review Comment: Should we remove the `IsDefault` field since it is version 0 only? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
