jeffkbkim commented on code in PR #18261:
URL: https://github.com/apache/kafka/pull/18261#discussion_r1890903359
##########
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala:
##########
@@ -1069,7 +1070,7 @@ object GroupMetadataManager {
* @return key for offset commit message
*/
def offsetCommitKey(groupId: String, topicPartition: TopicPartition):
Array[Byte] = {
-
MessageUtil.toVersionPrefixedBytes(OffsetCommitKey.HIGHEST_SUPPORTED_VERSION,
+
MessageUtil.toVersionPrefixedBytes(CoordinatorRecordType.OFFSET_COMMIT.id(),
Review Comment:
it doesn't seem like this change alters the schema written/read to/from the
log, but i want to confirm that this doesn't break compatibility. should we
have a test for this? my question is if there is a bug in one of the record
format changes, would that be caught somewhere?
also, internal coordinator topics (txn state) can use this but the
difference would be to use a unique api key instead now, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
