AndrewJSchofield commented on code in PR #18261:
URL: https://github.com/apache/kafka/pull/18261#discussion_r1893267086
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorShard.java:
##########
@@ -755,6 +759,26 @@ public void onNewMetadataImage(MetadataImage newImage,
MetadataDelta delta) {
offsetMetadataManager.onNewMetadataImage(newImage, delta);
}
+ private static OffsetCommitKey convertOffsetCommitKeyV0(
Review Comment:
I think the rename to LegacyOffsetCommit is a good idea. This method and the
next one for converting the value still use the V0 naming. I suggest renaming
to LegacyOffsetCommit too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
