jeffkbkim commented on code in PR #18261:
URL: https://github.com/apache/kafka/pull/18261#discussion_r1892663979
##########
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala:
##########
@@ -1167,13 +1167,18 @@ object GroupMetadataManager {
val version = buffer.getShort
try {
CoordinatorRecordType.fromId(version) match {
+ case CoordinatorRecordType.LEGACY_OFFSET_COMMIT =>
+ // version 0 refers to the legacy offset commit.
+ val key = new LegacyOffsetCommitKey(new ByteBufferAccessor(buffer),
0.toShort)
+ OffsetKey(version, GroupTopicPartition(key.group, new
TopicPartition(key.topic, key.partition)))
+
case CoordinatorRecordType.OFFSET_COMMIT |
CoordinatorRecordType.LEGACY_OFFSET_COMMIT =>
Review Comment:
should
```
| CoordinatorRecordType.LEGACY_OFFSET_COMMIT
```
now be removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
