srdo commented on code in PR #17139:
URL: https://github.com/apache/kafka/pull/17139#discussion_r1897938086
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/metrics/KafkaConsumerMetrics.java:
##########
@@ -68,6 +67,7 @@ public KafkaConsumerMetrics(Metrics metrics, String
metricGrpPrefix) {
metricGroupName,
"The average fraction of time the consumer's poll() is idle as
opposed to waiting for the user code to process records."),
new Avg());
+ this.pollIdleRatio = new TimeRatio2(metrics.config().timeWindowMs(),
pollIdleSensor);
Review Comment:
I'm a bit unsure whether it would be better to select a smaller time window
here. The defaults for the metrics system is a window of 30 seconds, which is a
bit large for this purpose, and it also only keeps 2 samples. It might make
sense to aim for e.g. a sample every few seconds, or 1/5th the window size the
metrics system uses, or something like that.
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/metrics/KafkaConsumerMetrics.java:
##########
@@ -68,6 +67,7 @@ public KafkaConsumerMetrics(Metrics metrics, String
metricGrpPrefix) {
metricGroupName,
"The average fraction of time the consumer's poll() is idle as
opposed to waiting for the user code to process records."),
new Avg());
+ this.pollIdleRatio = new TimeRatio2(metrics.config().timeWindowMs(),
pollIdleSensor);
Review Comment:
I'm a bit unsure whether it would be better to select a smaller time window
here. The defaults for the metrics system is a window of 30 seconds, which is a
bit large for this purpose, and it also only keeps 2 samples. It might make
sense to aim for e.g. a sample every few seconds, or 1/5th the window size the
metric system uses, or something like that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
