ijuma commented on code in PR #18232:
URL: https://github.com/apache/kafka/pull/18232#discussion_r1900424589
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchMetricsManager.java:
##########
@@ -181,6 +195,67 @@ void maybeUpdateAssignment(SubscriptionState subscription)
{
}
}
+ @Deprecated // To be removed in Kafka 5.0 release.
+ private void maybeRecordDeprecatedBytesFetched(String name, String topic,
int bytes) {
Review Comment:
Generally speaking, we should always include a note explaining the
deprecation. This should include the first version it was deprecated, when it's
expected to be removed and what should be used instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
