ijuma commented on code in PR #18232:
URL: https://github.com/apache/kafka/pull/18232#discussion_r1900424725
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchMetricsManager.java:
##########
@@ -197,22 +274,34 @@ private static String
partitionRecordsLagMetricName(TopicPartition tp) {
return tp + ".records-lag";
}
+ private static String deprecatedMetricName(String name) {
+ return name + ".deprecated";
+ }
+
+ private static boolean shouldReportDeprecatedMetric(String topic) {
+ return topic.contains(".");
+ }
+
private MetricName partitionPreferredReadReplicaMetricName(TopicPartition
tp) {
+ Map<String, String> metricTags = mkMap(mkEntry("topic", tp.topic()),
mkEntry("partition", String.valueOf(tp.partition())));
+ return
this.metrics.metricInstance(metricsRegistry.partitionPreferredReadReplica,
metricTags);
+ }
+
+ @Deprecated
Review Comment:
We should never deprecate something without including a @deprecated javadoc
with the details I outlined in a separate comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
