apoorvmittal10 commented on code in PR #18232:
URL: https://github.com/apache/kafka/pull/18232#discussion_r1900780156
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchMetricsManager.java:
##########
@@ -181,6 +195,67 @@ void maybeUpdateAssignment(SubscriptionState subscription)
{
}
}
+ @Deprecated // To be removed in Kafka 5.0 release.
+ private void maybeRecordDeprecatedBytesFetched(String name, String topic,
int bytes) {
Review Comment:
Sure, so currently below `Note` has been added to metrics.
#### Current:
```
"Note: For topic names with periods (.), an additional metric with
underscores is emitted.
However, the periods replaced metric is deprecated.
Please use the metric with actual topic name instead."
```
Example:
<img width="247" alt="Screenshot 2025-01-02 at 11 21 27"
src="https://github.com/user-attachments/assets/f5395b1c-f6df-4006-b303-63b4db3c08d8";
/>
#### Should we change it to:
```
"Note: For topic names with periods (.), an additional metric with
underscores is emitted.
However, the periods replaced metric is deprecated since Kafka 4.1 and shall
be removed in Kafka 5.0.
Please use the metric with actual topic name instead."
```
wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
