ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1902116235
##########
raft/src/test/java/org/apache/kafka/raft/internals/KafkaRaftMetricsTest.java:
##########
@@ -162,16 +218,18 @@ public void shouldRecordVoterQuorumState(KRaftVersion
kraftVersion) {
getMetric(metrics, "current-vote-directory-id").metricValue()
);
assertEquals((double) 1, getMetric(metrics,
"current-epoch").metricValue());
- assertEquals((double) -1L, getMetric(metrics,
"high-watermark").metricValue());
+ assertEquals((double) -1L, getMetric(metrics,
"high-watermark").metricValue()); // todo, bug fix
Review Comment:
@jsancio the HW drops to -1L after candidate transitions to leader - if you
agree this is a bug I'll file a Jira for this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
