jsancio commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1917401126
##########
raft/src/test/java/org/apache/kafka/raft/RaftClientTestContext.java:
##########
@@ -1824,71 +1933,74 @@ UpdateRaftVoterResponseData updateVoterResponse(
}
private short fetchRpcVersion() {
- if (kip853Rpc) {
+ if (raftProtocol.isReconfigSupported()) {
return 17;
} else {
return 16;
}
}
private short fetchSnapshotRpcVersion() {
- if (kip853Rpc) {
+ if (raftProtocol.isReconfigSupported()) {
return 1;
} else {
return 0;
}
}
short voteRpcVersion() {
- if (kip853Rpc) {
- return ApiKeys.VOTE.latestVersion();
+ if (raftProtocol.isPreVoteSupported()) {
+ return 2;
+ }
+ if (raftProtocol.isReconfigSupported()) {
+ return 1;
} else {
return 0;
}
Review Comment:
I take it back. This implementation is fine if you want to keep it. Maybe
just make it `else if (raftProtocol.isReconfigSupported()) {`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
