ahuang98 commented on code in PR #18240: URL: https://github.com/apache/kafka/pull/18240#discussion_r1917357351
########## raft/src/test/java/org/apache/kafka/raft/RaftClientTestContext.java: ########## @@ -292,8 +308,16 @@ Builder withBootstrapServers(Optional<List<InetSocketAddress>> bootstrapServers) return this; } - Builder withKip853Rpc(boolean kip853Rpc) { - this.kip853Rpc = kip853Rpc; + // deprecated, use withRpc instead + Builder withKip853Rpc(boolean withKip853Rpc) { + if (withKip853Rpc) { + this.raftProtocol = KIP_853_PROTOCOL; + } + return this; + } Review Comment: https://issues.apache.org/jira/browse/KAFKA-18561 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org