chia7712 commented on code in PR #18432:
URL: https://github.com/apache/kafka/pull/18432#discussion_r1910917574
##########
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##########
@@ -598,6 +531,21 @@ class KafkaApisTest extends Logging {
)
}
+ private def testNewBodyForwardableApi(request: RequestChannel.Request
+ ): Unit = {
+ val forwardCallback: ArgumentCaptor[Option[AbstractResponse] => Unit] =
ArgumentCaptor.forClass(classOf[Option[AbstractResponse] => Unit])
+ val newBody: ArgumentCaptor[AbstractRequest] =
ArgumentCaptor.forClass(classOf[AbstractRequest])
+
+ verify(forwardingManager).forwardRequest(
Review Comment:
all we want to verify is the method `forwardRequest` gets executed only
once, right? the following assert is unnecessary as they never be null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
