clolov commented on code in PR #18432:
URL: https://github.com/apache/kafka/pull/18432#discussion_r1913025607
##########
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##########
@@ -485,44 +412,6 @@ class KafkaApisTest extends Logging {
}
}
- @Test
- def testAlterConfigsWithAuthorizer(): Unit = {
Review Comment:
Apologies if I am missing something obvious, but here is my reasoning. If we
keep authorization in IncrementalAlterConfigs before forwarding to the KRaft
controller, then we ought to keep authorization in the AlterConfigs as well,
regardless of whether the API is deprecated or not. As far as I can see,
`processLegacyAlterConfigsRequest` used to carry out the authorisation w.r.t
AlterConfigs. Am I wrong in my reading of the code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
