lianetm commented on code in PR #18554:
URL: https://github.com/apache/kafka/pull/18554#discussion_r1917209707
##########
core/src/test/scala/integration/kafka/api/ConsumerRebootstrapTest.scala:
##########
@@ -135,8 +135,8 @@ object ConsumerRebootstrapTest {
final val RebootstrapTestName =
s"${TestInfoUtils.TestWithParameterizedQuorumAndGroupProtocolNames}.useRebootstrapTriggerMs={2}"
def rebootstrapTestParams: stream.Stream[Arguments] = {
- assertEquals(1,
getTestQuorumAndGroupProtocolParametersClassicGroupProtocolOnly.count())
- val args = getTestQuorumAndGroupProtocolParametersClassicGroupProtocolOnly
+ assertEquals(2, getTestQuorumAndGroupProtocolParametersAll.count())
+ val args = getTestQuorumAndGroupProtocolParametersAll
.findFirst().get.get
Review Comment:
if we're only keeping the first entry from the full protocol list we still
won't be testing with both consumers right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
