lianetm commented on code in PR #18554:
URL: https://github.com/apache/kafka/pull/18554#discussion_r1918791042
##########
core/src/test/scala/integration/kafka/api/ConsumerRebootstrapTest.scala:
##########
@@ -135,12 +135,13 @@ object ConsumerRebootstrapTest {
final val RebootstrapTestName =
s"${TestInfoUtils.TestWithParameterizedQuorumAndGroupProtocolNames}.useRebootstrapTriggerMs={2}"
def rebootstrapTestParams: stream.Stream[Arguments] = {
- assertEquals(1,
getTestQuorumAndGroupProtocolParametersClassicGroupProtocolOnly.count())
- val args = getTestQuorumAndGroupProtocolParametersClassicGroupProtocolOnly
- .findFirst().get.get
- stream.Stream.of(
- Arguments.of((args :+ true):_*),
- Arguments.of((args :+ false):_*)
- )
+ assertEquals(2, getTestQuorumAndGroupProtocolParametersAll.count())
Review Comment:
makes sense to me to remove it, this test shouldn't care about the elements
in the list, just make sure we use them all right? (this is the only comment
left here imo @TaiJuWu, please take a look when you can and I'll take another
look). Thanks!
##########
core/src/test/scala/integration/kafka/api/ConsumerRebootstrapTest.scala:
##########
@@ -135,12 +135,13 @@ object ConsumerRebootstrapTest {
final val RebootstrapTestName =
s"${TestInfoUtils.TestWithParameterizedQuorumAndGroupProtocolNames}.useRebootstrapTriggerMs={2}"
def rebootstrapTestParams: stream.Stream[Arguments] = {
- assertEquals(1,
getTestQuorumAndGroupProtocolParametersClassicGroupProtocolOnly.count())
- val args = getTestQuorumAndGroupProtocolParametersClassicGroupProtocolOnly
- .findFirst().get.get
- stream.Stream.of(
- Arguments.of((args :+ true):_*),
- Arguments.of((args :+ false):_*)
- )
+ assertEquals(2, getTestQuorumAndGroupProtocolParametersAll.count())
Review Comment:
makes sense to me to remove it, this test shouldn't care about the elements
in the list, just make sure we use them all right? (this is the only comment
left here imo @TaiJuWu, please take a look when you can and I'll take another
look too). Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
