Re: [PR] KAFKA-18529: PlaintextAdminIntegrationTest and ConsumerRebootstrapTest should run for async consumer [kafka]

[via GitHub]

kirktrue commented on PR #18554:
URL: https://github.com/apache/kafka/pull/18554#issuecomment-2599348638

   To test whether or not a test needed to be updated, I changed the code that 
creates a `Consumer`:
   
   ```diff
   diff --git 
a/clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerDelegateCreator.java
 
b/clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerDelegateCreator.java
   index 74592972b9..fe70aebcee 100644
   --- 
a/clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerDelegateCreator.java
   +++ 
b/clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerDelegateCreator.java
   @@ -56,6 +56,9 @@ public class ConsumerDelegateCreator {
        public <K, V> ConsumerDelegate<K, V> create(ConsumerConfig config,
                                                    Deserializer<K> 
keyDeserializer,
                                                    Deserializer<V> 
valueDeserializer) {
   +        if (true)
   +            throw new RuntimeException("Intentionally blocking attempt to 
create a Consumer!");
   +
            try {
                GroupProtocol groupProtocol = 
GroupProtocol.valueOf(config.getString(ConsumerConfig.GROUP_PROTOCOL_CONFIG).toUpperCase(Locale.ROOT));
    
   @@ -79,6 +82,9 @@ public class ConsumerDelegateCreator {
                                                    SubscriptionState 
subscriptions,
                                                    ConsumerMetadata metadata,
                                                    
List<ConsumerPartitionAssignor> assignors) {
   +        if (true)
   +            throw new RuntimeException("Intentionally blocking attempt to 
create a Consumer!");
   +
            try {
                GroupProtocol groupProtocol = 
GroupProtocol.valueOf(config.getString(ConsumerConfig.GROUP_PROTOCOL_CONFIG).toUpperCase(Locale.ROOT));
    
   ```
   
   Then I ran `PlaintextAdminIntegrationTest` locally.
   
   Are there other changes in the queue that are going to start creating 
`Consumer`s in these tests?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org