apoorvmittal10 commented on code in PR #18444:
URL: https://github.com/apache/kafka/pull/18444#discussion_r1920147109
##########
core/src/main/java/kafka/server/share/SharePartitionManager.java:
##########
@@ -695,6 +735,21 @@ private static void removeSharePartitionFromCache(
}
}
+ /**
+ * The handler to update the failed share acknowledge request metrics.
+ *
+ * @return A Consumer that updates the failed share acknowledge request
metrics.
+ */
+ private Consumer<Collection<String>>
failedShareAcknowledgeMetricsHandler() {
Review Comment:
Done.
##########
core/src/main/java/kafka/server/share/SharePartitionManager.java:
##########
@@ -363,24 +387,31 @@ public CompletableFuture<Map<TopicIdPartition,
ShareAcknowledgeResponseData.Part
}
});
- return mapAcknowledgementFutures(futuresMap);
+ return mapAcknowledgementFutures(futuresMap, Optional.empty());
}
- private CompletableFuture<Map<TopicIdPartition,
ShareAcknowledgeResponseData.PartitionData>>
mapAcknowledgementFutures(Map<TopicIdPartition, CompletableFuture<Throwable>>
futuresMap) {
+ private CompletableFuture<Map<TopicIdPartition,
ShareAcknowledgeResponseData.PartitionData>> mapAcknowledgementFutures(
+ Map<TopicIdPartition, CompletableFuture<Throwable>> futuresMap,
+ Optional<Consumer<Collection<String>>> metricsHandler
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
