apoorvmittal10 commented on code in PR #18444:
URL: https://github.com/apache/kafka/pull/18444#discussion_r1928775590
##########
core/src/main/java/kafka/server/share/SharePartitionManager.java:
##########
@@ -598,6 +632,12 @@ void processShareFetch(ShareFetch shareFetch) {
sharePartitions.put(topicIdPartition, sharePartition);
}
+ // Update the metrics for the topics for which we have received a
share fetch request.
+ topics.forEach(topic -> {
+
brokerTopicStats.allTopicsStats().totalShareFetchRequestRate().mark();
Review Comment:
@chia7712 yes you are right, as discussed in the thread as well
[here](https://github.com/apache/kafka/pull/18444#discussion_r1909573910), I
have created the task to fix that:
https://issues.apache.org/jira/browse/KAFKA-18640
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
