junrao commented on code in PR #18444:
URL: https://github.com/apache/kafka/pull/18444#discussion_r1920680591
##########
core/src/main/java/kafka/server/share/SharePartitionManager.java:
##########
@@ -598,6 +632,12 @@ void processShareFetch(ShareFetch shareFetch) {
sharePartitions.put(topicIdPartition, sharePartition);
}
+ // Update the metrics for the topics for which we have received a
share fetch request.
+ topics.forEach(topic -> {
+
brokerTopicStats.allTopicsStats().totalShareFetchRequestRate().mark();
Review Comment:
We can keep the per topic one, but we don't need the one that aggregates
across all topics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
