ijuma commented on code in PR #18497:
URL: https://github.com/apache/kafka/pull/18497#discussion_r1921655537


##########
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##########
@@ -4732,67 +4549,6 @@ class ReplicaManagerTest {
     }
   }
 
-  @Test
-  def testPartitionMetadataFileCreatedAfterPreviousRequestWithoutIds(): Unit = 
{

Review Comment:
   @jolshan I believe this 
and`testPartitionFetchStateUpdatesWithTopicIdChanges` are no longer necessary 
since KRaft always requires topic ids to be set and 4.0 only supports upgrades 
from clusters already running in kraft mode. Do you agree or are there reasons 
to try to make these tests work?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to