ijuma commented on code in PR #18497:
URL: https://github.com/apache/kafka/pull/18497#discussion_r1921659893
##########
core/src/test/scala/unit/kafka/server/ShareGroupHeartbeatRequestTest.scala:
##########
@@ -894,7 +894,7 @@ class ShareGroupHeartbeatRequestTest(cluster:
ClusterInstance) {
val allPartitionsMetadata =
waitForAllPartitionsMetadata(brokersToValidate, topic, totalPartitionCount)
(0 until totalPartitionCount - 1).foreach(i => {
allPartitionsMetadata.get(new TopicPartition(topic, i)).foreach {
partitionMetadata =>
- assertEquals(totalPartitionCount, partitionMetadata.replicas.size)
+ assertEquals(totalPartitionCount, partitionMetadata.isr.size)
Review Comment:
This is not exactly the same behavior, but the updated behavior is fine for
the test (since isr and replicas is the same). The reason for the change is
that the replicas are no longer returned by the method being used here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
