AndrewJSchofield commented on code in PR #18649:
URL: https://github.com/apache/kafka/pull/18649#discussion_r1923396299
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -846,16 +846,15 @@ private ShareGroup getOrMaybeCreateShareGroup(
if (group == null) {
return new ShareGroup(snapshotRegistry, groupId);
+ } else {
+ if (group.type() == SHARE) {
+ return (ShareGroup) group;
+ } else {
+ // We don't support upgrading/downgrading between protocols at
the moment so
+ // we throw an exception if a group exists with the wrong type.
+ throw new GroupIdNotFoundException(String.format("Group %s is
not a share group.", groupId));
+ }
}
-
- if (group.type() != SHARE) {
- // We don't support upgrading/downgrading between protocols at the
moment so
- // we throw an exception if a group exists with the wrong type.
- throw new GroupIdNotFoundException(String.format("Group %s is not
a share group.",
- groupId));
- }
-
- return (ShareGroup) group;
Review Comment:
Just to match consumer groups. I prefer having the code structure the same
shape so it's easier to compare visually. That way, if there's a need to make a
code change to one, it's easier to validate and apply to the other too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
