apoorvmittal10 commented on code in PR #18649:
URL: https://github.com/apache/kafka/pull/18649#discussion_r1923405550
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -2032,11 +2031,10 @@ private
CoordinatorResult<ShareGroupHeartbeatResponseData, CoordinatorRecord> sh
// Get or create the share group.
boolean createIfNotExists = memberEpoch == 0;
- final ShareGroup group = getOrMaybeCreatePersistedShareGroup(groupId,
createIfNotExists);
+ final ShareGroup group = getOrMaybeCreateShareGroup(groupId,
createIfNotExists);
Review Comment:
I have to recall, there might be reasons to move differently or a mistake. I
ll look into the details again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
