lianetm commented on code in PR #18554:
URL: https://github.com/apache/kafka/pull/18554#discussion_r1924158432
##########
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##########
@@ -207,10 +207,10 @@ class PlaintextAdminIntegrationTest extends
BaseAdminIntegrationTest {
Admin.create(config)
}
- @ParameterizedTest(name =
TestInfoUtils.TestWithParameterizedQuorumAndGroupProtocolNames)
- @MethodSource(Array("getTestQuorumAndGroupProtocolParametersAll"))
@Timeout(10)
- def testDescribeUserScramCredentialsTimeout(quorum: String, groupProtocol:
String): Unit = {
+ @ParameterizedTest
+ @ValueSource(strings = Array("kraft"))
Review Comment:
agree with this change, but interesting, this shows that
`PlainTestAdminIntegration` was already running for async in cases where it was
not needed, right?
So checking all these admin tests that were running for both consumers, I
notice that `testLogStartOffsetCheckpoint` is somehow similar to this one,
should we apply the same fix to it?
It's running for both but it really only uses a consumer to
`subscribeAndWaitForAssignment`, which is already covered in many
consumer-specific tests, is it valuable in this testLogStartOffsetCheckpoint?
(seems unrelated). What do you think @kirktrue ? I see you enabled it for both
consumers as part of https://github.com/apache/kafka/pull/17670.
Also should we rename the jira/PR? It's only the ConsumerRebotstrap that was
not running for async
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
