chia7712 commented on code in PR #18554:
URL: https://github.com/apache/kafka/pull/18554#discussion_r1926899717
##########
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##########
@@ -207,10 +207,10 @@ class PlaintextAdminIntegrationTest extends
BaseAdminIntegrationTest {
Admin.create(config)
}
- @ParameterizedTest(name =
TestInfoUtils.TestWithParameterizedQuorumAndGroupProtocolNames)
- @MethodSource(Array("getTestQuorumAndGroupProtocolParametersAll"))
@Timeout(10)
- def testDescribeUserScramCredentialsTimeout(quorum: String, groupProtocol:
String): Unit = {
+ @ParameterizedTest
+ @ValueSource(strings = Array("kraft"))
Review Comment:
> but I haven't yet thought about the heuristic to apply to know when it's
"safe" to just test the one consumer or the other.
we are on the same page :)
It's difficult to definitively confirm that "this functionality of the
consumer is already covered by another test." Therefore, a simpler approach is
to test both consumers if the test requires the use of a consumer.
Maybe we can revisit only the "slow" tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
