CalvinConfluent commented on code in PR #18680: URL: https://github.com/apache/kafka/pull/18680#discussion_r1940117855
########## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ########## @@ -113,15 +113,15 @@ public enum MetadataVersion { // Bootstrap metadata version for version 1 of the GroupVersion feature (KIP-848). IBP_4_0_IV0(22, "4.0", "IV0", false), + // Add ELR related supports (KIP-966). Review Comment: Done. ########## metadata/src/main/java/org/apache/kafka/image/writer/ImageWriterOptions.java: ########## @@ -30,6 +31,7 @@ public final class ImageWriterOptions { public static class Builder { private MetadataVersion metadataVersion; private MetadataVersion requestedMetadataVersion; + private Map<String, Short> finalizedFeatures; Review Comment: Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org