cmccabe commented on code in PR #18680:
URL: https://github.com/apache/kafka/pull/18680#discussion_r1942035435
##########
metadata/src/main/java/org/apache/kafka/image/loader/MetadataLoader.java:
##########
@@ -295,6 +296,9 @@ void initializeNewPublishers() {
ImageReWriter writer = new ImageReWriter(delta);
image.write(writer, new ImageWriterOptions.Builder().
setMetadataVersion(image.features().metadataVersion()).
+ setEligibleLeaderReplicasEnabled(
+
image.features().finalizedVersions().getOrDefault(EligibleLeaderReplicasVersion.FEATURE_NAME,
EligibleLeaderReplicasVersion.ELRV_0.featureLevel())
Review Comment:
can we add a function in FeaturesImage.java like `isElrEnabled` to simplify
this a bit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
