CalvinConfluent commented on code in PR #18680:
URL: https://github.com/apache/kafka/pull/18680#discussion_r1943331870
##########
metadata/src/main/java/org/apache/kafka/metadata/PartitionRegistration.java:
##########
@@ -387,7 +387,7 @@ public ApiMessageAndVersion toRecord(Uuid topicId, int
partitionId, ImageWriterO
setLeaderRecoveryState(leaderRecoveryState.value()).
setLeaderEpoch(leaderEpoch).
setPartitionEpoch(partitionEpoch);
- if (options.metadataVersion().isElrSupported()) {
+ if (options.isEligibleLeaderReplicasEnabled()) {
Review Comment:
I assume it is not relevant to this PR but I add the metadata check here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
