ijuma commented on code in PR #18845: URL: https://github.com/apache/kafka/pull/18845#discussion_r1953228668
########## metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java: ########## @@ -495,7 +495,9 @@ BrokerFeature processRegistrationFeature( FinalizedControllerFeatures finalizedFeatures, BrokerRegistrationRequestData.Feature feature ) { - int defaultVersion = feature.name().equals(MetadataVersion.FEATURE_NAME) ? 1 : 0; // The default value for MetadataVersion is 1 not 0. + // The default value for MetadataVersion changes over time while other features start at `0` + int defaultVersion = feature.name().equals(MetadataVersion.FEATURE_NAME) ? + MetadataVersion.MINIMUM_VERSION.featureLevel() : 0; Review Comment: I can try. We have one test failing only in CI due to the minimum being used, perhaps this will help. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org