ijuma commented on code in PR #18845:
URL: https://github.com/apache/kafka/pull/18845#discussion_r1956516319


##########
metadata/src/main/java/org/apache/kafka/image/loader/MetadataBatchLoader.java:
##########
@@ -100,7 +100,7 @@ public boolean hasSeenRecord() {
      */
     public final void resetToImage(MetadataImage image) {
         this.image = image;
-        this.hasSeenRecord = true;
+        this.hasSeenRecord = !image.isEmpty();

Review Comment:
   This was an existing issue that somehow became easier to trigger due to 
these changes. Thanks to @mumrah for figuring out that this was the reason for 
the remaining failures.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to