mumrah commented on code in PR #18845:
URL: https://github.com/apache/kafka/pull/18845#discussion_r1956762973
##########
metadata/src/main/java/org/apache/kafka/image/node/MetadataNode.java:
##########
@@ -53,7 +53,8 @@ default void print(MetadataNodePrinter printer) {
for (String name : names) {
printer.enterNode(name);
MetadataNode child = child(name);
- child.print(printer);
+ if (child != null)
+ child.print(printer);
Review Comment:
Hm, it's definitely a bug, but I don't think it relates to this PR. The
*Node classes are used by the metadata shell and some toString methods, so they
are just informational. I think the exact side effect is that acls would appear
at the wrong level of the metadata shell "tree".
I suggest we file a separate issue and fix it for 4.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
