ijuma commented on code in PR #18845: URL: https://github.com/apache/kafka/pull/18845#discussion_r1957186684
########## metadata/src/main/java/org/apache/kafka/image/FeaturesImage.java: ########## @@ -56,7 +53,7 @@ public FeaturesImage( public boolean isEmpty() { return finalizedVersions.isEmpty() && - metadataVersion.equals(MetadataVersion.MINIMUM_KRAFT_VERSION); + metadataVersion.equals(MetadataVersion.MINIMUM_VERSION); Review Comment: It turns out that this had to be fixed for all the tests to pass. Addressed in the latest commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org