ShivsundarR commented on code in PR #19192:
URL: https://github.com/apache/kafka/pull/19192#discussion_r1993560759
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumeRequestManager.java:
##########
@@ -527,8 +533,12 @@ public CompletableFuture<Map<TopicIdPartition,
Acknowledgements>> commitSync(
* Enqueue an AcknowledgeRequestState to be picked up on the next poll.
*
* @param acknowledgementsMap The acknowledgements to commit
+ * @param defaultTimeoutMs Timeout which would be used when the request
is retried, i.e. if it fails with
Review Comment:
Yes, I was thinking as we need to pass in the `defaultTimeoutApi` config
from ConsumerConfig over to the background thread, we can use that to create
the timer for `commitAsync()`. So essentially we are starting the timer only in
the background thread, whereas for `commitSync()` and `close()` we would
predetermine the deadline in the application thread.
If we want to stick to the same way across the 3 methods, we have to then
pass in a timer object to the application events using which we can determine
both the deadline and the timeout which was configured. We can do that as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
