AndrewJSchofield commented on code in PR #19192:
URL: https://github.com/apache/kafka/pull/19192#discussion_r2006786717
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ShareConsumeRequestManagerTest.java:
##########
@@ -2266,9 +2376,8 @@ void testLeadershipChangeAfterFetchBeforeClose() {
Acknowledgements acknowledgementsTp0 = Acknowledgements.empty();
acknowledgementsTp0.add(1L, AcknowledgeType.ACCEPT);
- Acknowledgements acknowledgementsTp1 = Acknowledgements.empty();
- acknowledgementsTp1.add(1L, AcknowledgeType.ACCEPT);
- acknowledgementsTp1.add(2L, AcknowledgeType.ACCEPT);
+ Acknowledgements acknowledgementsTp1 = getAcknowledgements(1,
Review Comment:
I would expect this:
```
Acknowledgements acknowledgementsTp1 = getAcknowledgements(1,
AcknowledgeType.ACCEPT, AcknowledgeType.ACCEPT);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
