ShivsundarR commented on code in PR #19192:
URL: https://github.com/apache/kafka/pull/19192#discussion_r2012627441
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ShareConsumeRequestManagerTest.java:
##########
@@ -652,19 +633,15 @@ public void testBatchingAcknowledgeRequestStates() {
networkClientDelegate.poll(time.timer(0));
assertTrue(shareConsumeRequestManager.hasCompletedFetches());
- Acknowledgements acknowledgements = Acknowledgements.empty();
- acknowledgements.add(1L, AcknowledgeType.ACCEPT);
- acknowledgements.add(2L, AcknowledgeType.ACCEPT);
- acknowledgements.add(3L, AcknowledgeType.REJECT);
+ Acknowledgements acknowledgements = getAcknowledgements(1,
AcknowledgeType.ACCEPT, AcknowledgeType.ACCEPT, AcknowledgeType.REJECT);
- shareConsumeRequestManager.commitAsync(Map.of(tip0, new
NodeAcknowledgements(0, acknowledgements)));
+ shareConsumeRequestManager.commitAsync(Map.of(tip0, new
NodeAcknowledgements(0, acknowledgements)),
+ calculateDeadlineMs(time.timer(defaultApiTimeoutMs)));
- Acknowledgements acknowledgements2 = Acknowledgements.empty();
- acknowledgements.add(4L, AcknowledgeType.ACCEPT);
- acknowledgements.add(5L, AcknowledgeType.ACCEPT);
- acknowledgements.add(6L, AcknowledgeType.ACCEPT);
+ Acknowledgements acknowledgements2 = getAcknowledgements(4,
AcknowledgeType.ACCEPT, AcknowledgeType.ACCEPT, AcknowledgeType.REJECT);
Review Comment:
Yes, I thought we could have a different acknowledge type like the other
parts of the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
