ShivsundarR commented on code in PR #19192:
URL: https://github.com/apache/kafka/pull/19192#discussion_r2012630742
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumeRequestManager.java:
##########
@@ -1242,6 +1271,10 @@ void processingComplete() {
processPendingInFlightAcknowledgements(new
InvalidRecordStateException(INVALID_RESPONSE));
resultHandler.completeIfEmpty();
isProcessed = true;
+ maybeResetTimerAndRequestState();
+ if (requestType == AcknowledgeRequestType.CLOSE) {
Review Comment:
Right, that makes sense. I have now moved the check to the request manager
and updated the logic to just check for the `isProcessed` boolean to avoid
infinite retries. The existing prune logic would take care of setting it to
null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
