apalan60 commented on code in PR #19327:
URL: https://github.com/apache/kafka/pull/19327#discussion_r2023533282
##########
clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java:
##########
@@ -220,14 +220,6 @@ public static int
recordsSize(FetchResponseData.PartitionData partition) {
return partition.records() == null ? 0 :
partition.records().sizeInBytes();
}
- // TODO: remove as a part of KAFKA-12410
Review Comment:
@junrao
Thanks for your review.
The other ```of``` constructor is currently used by ```KafkaApis``` in
production code. I'm looking into alternative approaches to remove this
dependency, so that we can achieve the deletion behavior mentioned in the TODO
comment. I'll update the thread if I manage to come up with a viable solution.
If I've misunderstood anything, please let me know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
