apalan60 commented on PR #19327: URL: https://github.com/apache/kafka/pull/19327#issuecomment-2780865513
Hi @junrao , @ijuma , @FrankYang0529 Sorry for the late update. I’ve now updated the PR with the following adjustments: In the original version, FetchResponse had two ```#of``` methods: [#of-1](https://github.com/apache/kafka/blob/8c77953d5fa84ce1dfdf83f73560444a4acabc1f/clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java#L224) and [#of-2](https://github.com/apache/kafka/blob/8c77953d5fa84ce1dfdf83f73560444a4acabc1f/clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java#L232). ```#of-1``` was only used in tests and benchmarks, while ```#of-2``` is used by ```FetchSession```. My current changes only target ```#of-1```. Since it is not used in production, I removed it, and updated the tests that originally called it to instead invoke ```#of-2``` to maintain the original testing logic. ```#of-2``` remains unchanged in this PR because removing it would have a larger impact. If you see any issues or have any concerns, please let me know and I’ll address them as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
