ijuma commented on PR #19327: URL: https://github.com/apache/kafka/pull/19327#issuecomment-2780917690
I don't understand what we are trying to achieve here. It would be good to agree on the goal first. Generally speaking, it's not a strict requirement to remove a method if it's only used by tests. This can make sense if having the overload may lead to bugs in prod due to not passing all the parameters. But then it's helpful to have a test utility method versus adding verbosity to all the tests. @chia7712 What did you have in mind here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
