chia7712 commented on code in PR #19366:
URL: https://github.com/apache/kafka/pull/19366#discussion_r2027536151
##########
clients/src/main/java/org/apache/kafka/clients/consumer/AcknowledgementCommitCallback.java:
##########
@@ -34,6 +34,7 @@
* The callback may be executed in any thread calling {@link
ShareConsumer#poll(java.time.Duration)}.
*/
@InterfaceStability.Evolving
+@FunctionalInterface
Review Comment:
> It's still a callback meaning I don't think there's any particular reason
not to have the annotation
Excuse me, do you mean "callback" should be functional interface? If so, it
is not the rule in code base. For example, `ConsumerRebalanceListener` is a
kind of callback, but it does not have `@FunctionalInterface`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
