Tombert commented on code in PR #19366:
URL: https://github.com/apache/kafka/pull/19366#discussion_r2027542000
##########
clients/src/main/java/org/apache/kafka/clients/consumer/AcknowledgementCommitCallback.java:
##########
@@ -34,6 +34,7 @@
* The callback may be executed in any thread calling {@link
ShareConsumer#poll(java.time.Duration)}.
*/
@InterfaceStability.Evolving
+@FunctionalInterface
Review Comment:
Forgive me a bit here, I'm still kind of learning the Kafka codebase, but I
just think that the word "callback" itself implies some form of "response
handler" function. I will stay within Kafka's nomenclature, I just thought
that that was more or less the terminology.
`ConsumerRebalanceListener` can't be made into a `@FunctionalInterface` in
its current state because it has more than one method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
