Tombert commented on code in PR #19366: URL: https://github.com/apache/kafka/pull/19366#discussion_r2027527786
########## clients/src/main/java/org/apache/kafka/clients/consumer/AcknowledgementCommitCallback.java: ########## @@ -34,6 +34,7 @@ * The callback may be executed in any thread calling {@link ShareConsumer#poll(java.time.Duration)}. */ @InterfaceStability.Evolving +@FunctionalInterface Review Comment: Is there any reason not to have it even now? It's still a callback meaning I don't think there's any particular reason not to have the annotation, but I will happily admit I'm wrong if you think it's bad. I can remove it if you think it's bad to put it in. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org