frankvicky commented on code in PR #19645:
URL: https://github.com/apache/kafka/pull/19645#discussion_r2074658787
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractMembershipManager.java:
##########
@@ -1450,16 +1439,12 @@ public LocalAssignment(long localEpoch, Map<Uuid,
SortedSet<Integer>> partitions
}
}
- public LocalAssignment(long localEpoch, SortedSet<TopicIdPartition>
topicIdPartitions) {
+ public LocalAssignment(long localEpoch, TopicIdPartitionSet
topicIdPartitions) {
this.localEpoch = localEpoch;
- this.partitions = new HashMap<>();
if (localEpoch == NONE_EPOCH && !topicIdPartitions.isEmpty()) {
throw new IllegalArgumentException("Local epoch must be set if
there are partitions");
}
Review Comment:
Should we consider checking the value before assigning it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
