AndrewJSchofield commented on code in PR #19645:
URL: https://github.com/apache/kafka/pull/19645#discussion_r2077796509
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractMembershipManager.java:
##########
@@ -708,8 +704,10 @@ public void onHeartbeatRequestGenerated() {
transitionTo(MemberState.STABLE);
} else {
log.debug("Member {} with epoch {} transitioned to {} after a
heartbeat was sent " +
- "to ack a previous reconciliation. New assignments are
ready to " +
- "be reconciled.", memberId, memberEpoch,
MemberState.RECONCILING);
+ "to ack a previous reconciliation. \n" +
+ "\t\tCurrent assignment: {} \n" +
+ "\t\tNew assignment to reconcile: {}\n",
Review Comment:
Any reason why this is not "Target assignment"? I wonder if there's a subtle
difference that I've failed to grasp.
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractMembershipManager.java:
##########
@@ -376,8 +370,8 @@ protected void processAssignmentReceived(Map<Uuid,
SortedSet<Integer>> assignmen
*/
private void replaceTargetAssignmentWithNewAssignment(Map<Uuid,
SortedSet<Integer>> assignment) {
currentTargetAssignment.updateWith(assignment).ifPresent(updatedAssignment -> {
- log.debug("Target assignment updated from {} to {}. Member will
reconcile it on the next poll.",
- currentTargetAssignment, updatedAssignment);
+ log.debug("Member {} updated it's target assignment from {} to {}.
Member will reconcile it on the next poll.",
Review Comment:
nit: "its"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
