AndrewJSchofield commented on code in PR #19759:
URL: https://github.com/apache/kafka/pull/19759#discussion_r2097405538
##########
core/src/main/java/kafka/server/share/DelayedShareFetch.java:
##########
@@ -191,26 +191,23 @@ public void onExpiration() {
* Complete the share fetch operation by fetching records for all
partitions in the share fetch request irrespective
* of whether they have any acquired records. This is called when the
fetch operation is forced to complete either
* because records can be acquired for some partitions or due to MaxWaitMs
timeout.
+ * <p>
+ * On operation timeout, onComplete is invoked, last try occurs to acquire
partitions and read
+ * from log, if acquired. The fetch will only happen from local log and
not tier log, on operation
Review Comment:
nit: I'd say "remote storage" rather than "tier log".
##########
core/src/main/java/kafka/server/share/DelayedShareFetch.java:
##########
@@ -349,7 +346,7 @@ public boolean tryComplete() {
releasePartitionLocks(topicPartitionData.keySet());
}
} else {
- log.trace("Can't acquire records for any partition in the
share fetch request for group {}, member {}, " +
+ log.trace("Can't acquire any partition in the share fetch
request for group {}, member {}, " +
Review Comment:
nit: "any partitions"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
