apoorvmittal10 commented on PR #19759: URL: https://github.com/apache/kafka/pull/19759#issuecomment-2897267180
> @apoorvmittal10 : Thanks for the PR. The code looks reasonable to me. Could you run TestPurgatoryPerformance to see if there is any perf degradation? I ran some tests and performance is same. ### After the chages: ``` --num 10000 --rate 100 --timeout 1000 --pct50 0.5 --pct75 0.75 # latency samples: pct75 = 0, pct50 = 0, min = 0, max = 7 # interval samples: rate = 100.068948, min = 0, max = 129 # enqueue rate (10000 requests): # <elapsed time ms> <target rate> <actual rate> <process cpu time ms> <G1 Old Generation count> <G1 Young Generation count> <G1 Old Generation time ms> <G1 Young Generation time ms> 101196 99.809364 99.806376 3240 0 2 0 8 ``` ``` --num 10000 --rate 1000 --timeout 1000 --pct50 0.5 --pct75 0.75 # latency samples: pct75 = 0, pct50 = 0, min = 0, max = 9 # interval samples: rate = 999.371395, min = 0, max = 14 # enqueue rate (10000 requests): # <elapsed time ms> <target rate> <actual rate> <process cpu time ms> <G1 Old Generation count> <G1 Young Generation count> <G1 Old Generation time ms> <G1 Young Generation time ms> 11104 989.902990 989.805008 1349 0 2 0 7 ``` ### Before changes: ``` --num 10000 --rate 100 --timeout 1000 --pct50 0.5 --pct75 0.75 # latency samples: pct75 = 0, pct50 = 0, min = 0, max = 9 # interval samples: rate = 100.020304, min = 0, max = 130 # enqueue rate (10000 requests): # <elapsed time ms> <target rate> <actual rate> <process cpu time ms> <G1 Old Generation count> <G1 Young Generation count> <G1 Old Generation time ms> <G1 Young Generation time ms> 102366 98.657274 98.652408 3444 0 2 0 8 --num 10000 --rate 1000 --timeout 1000 --pct50 0.5 --pct75 0.75 # latency samples: pct75 = 0, pct50 = 0, min = 0, max = 8 # interval samples: rate = 997.134236, min = 0, max = 14 # enqueue rate (10000 requests): # <elapsed time ms> <target rate> <actual rate> <process cpu time ms> <G1 Old Generation count> <G1 Young Generation count> <G1 Old Generation time ms> <G1 Young Generation time ms> 11218 978.665101 978.665101 1624 0 2 0 7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
