apoorvmittal10 commented on PR #19759: URL: https://github.com/apache/kafka/pull/19759#issuecomment-2893712701
> @apoorvmittal10 It is too cool to add response in comment, so I don't notice your response :) > > > For 2) tryComplete invocation is in lock itself and there is also a checck for isCompleted prior invocation: > > Should we update `safeTryCompleteOrElse` to ensure it check for `isCompleted` prior invocation. @chia7712 Ahhhh, my bad. I clicked edit instead of reply 🫣🤦♂️ My bad. safeTryCompleteOrElse is invoked when the operation is being added to purgatory, if tryComplete returns false then it gets added in purgatory. An operation should never have completed true when invoking safeTryCompleteOrElse. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
