jsancio commented on code in PR #19800: URL: https://github.com/apache/kafka/pull/19800#discussion_r2116128222
########## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ########## @@ -264,13 +267,15 @@ public short partitionRecordVersion() { } public short fetchRequestVersion() { - if (this.isAtLeast(IBP_3_9_IV0)) { + if (isAtLeast(IBP_4_1_IV1)) { + return 18; Review Comment: I think the confusion is that KRaft doesn't use MV. MV is used by the broker replica fetcher to negotiate the FETCH version. KRaft uses ApiVersions response to negotiate RPC versions. You used this negotiation in the PreVote implementation of the VOTE RPC. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org