lianetm commented on PR #19875: URL: https://github.com/apache/kafka/pull/19875#issuecomment-2941060495
Hi @hgh1472 , thanks for the patch! I guess the naming came from the fact that this throws only under a certain condition (if the group id is empty), therefore "maybeThrow...", makes sense? That being said, we can surely improve readability like you're suggesting, but being explicit about the condition I would say (otherwise I don't see much gain between maybeThrow vs throwIf). So something like `throwIfGroupIdEmpty` maybe? Also, we should change consistently on the `AsyncKafkaConsumer` I would expect. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
