hgh1472 commented on PR #19875: URL: https://github.com/apache/kafka/pull/19875#issuecomment-2947193386
@lianetm Would it be correct to understand your point as saying that `throwIfGroupIdEmpty` could be confusing because the term “empty” overlaps with both Optional.empty() and an empty String? In other words, the method is essentially checking whether the groupId is defined or not — is that right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
